Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README application instructions #134

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

leefaisonr
Copy link
Contributor

@leefaisonr leefaisonr commented Aug 25, 2023

closes #129

@leefaisonr leefaisonr requested a review from hackartisan August 25, 2023 18:41

To import the GuideCards records: `rake import:import_guide_cards`
To import the CardImage records: `rake import:import_card_images`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this requires some aws profile configuration; maybe that's worth noting here and fleshing out in the future when someone else tries to do it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anna,

I have updated the file with the requested changes. I included some instructions on setting up aws for a local machine (instructions based on onboarding.md). Do you think I should just leave it as a note, that aws setup is required, or that these instructions are detailed enough. Thanks!

Copy link
Member

@hackartisan hackartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a note that aws configuration will be required? If it's documentation you have easily accessible a link would be amazing, otherwise I think it's fine to leave it for now as just a heads up

Co-authored-by: Anna Headley <hackartisan@users.noreply.github.com>
Copy link
Member

@hackartisan hackartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great thank you!

@hackartisan hackartisan merged commit a7484c2 into main Aug 28, 2023
@hackartisan hackartisan deleted the i129-image-import-docs branch August 28, 2023 13:56
@hackartisan
Copy link
Member

I'll adding an issue link to the description

@leefaisonr
Copy link
Contributor Author

Sounds good, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to render images on local machine
2 participants