Add explicit buffer option #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build error seems to unrelated to my tests 🤔 |
|
okay, although this is definitely a if-you-know-what-you-are-doing option. can it generate a random file for the test instead of checking something in though, because this will bloat the download size needlessly |
|
Can do! Was just using one of the existing test fixtures. Did you notice the race condition in the append test? EDIT: Sorry I forgot I added a jpg. Will remove again, then you can squash merge |
|
merged into 1.1.0, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A concrete usecase is reading file chunks into the memory of a webassembly function for hashing