New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiprotocol iDMA: Add AXI Lite and OBI #20

Merged

thommythomaso merged 1 commit into master from obi-tbenz

Nov 11, 2022

Collaborator

thommythomaso commented Nov 8, 2022

No description provided.

thommythomaso added the enhancement label

thommythomaso requested a review from micprog

November 8, 2022 09:18

thommythomaso self-assigned this

thommythomaso commented

View reviewed changes

Bender.yml Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

README.md Show resolved Hide resolved

thommythomaso commented

View reviewed changes

jobs/backend/fails.txt Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

jobs/backend/man_simple.txt Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

test/obi2axi_bridge.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

test/per2axi.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

Collaborator Author

thommythomaso left a comment

So far it looks good to me, will have to check all *.sv files once more.

thommythomaso commented

View reviewed changes

src/idma_legalizer.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

src/idma_legalizer.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

src/idma_legalizer.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

src/idma_legalizer.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

src/idma_legalizer.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

src/idma_legalizer.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

src/idma_obi_transport_layer.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

src/idma_obi_transport_layer.sv Show resolved Hide resolved

thommythomaso commented

View reviewed changes

src/synth_wrapper/idma_lite_backend_synth.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

test/include/tb_tasks.svh Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

test/tb_idma_backend.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

test/tb_idma_backend.sv Show resolved Hide resolved

thommythomaso commented

View reviewed changes

test/tb_idma_obi_backend.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

test/tb_idma_obi_backend.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

src/idma_backend.sv Outdated Show resolved Hide resolved

thommythomaso commented

View reviewed changes

Collaborator Author

thommythomaso left a comment

Looks good. Minor comments in line. Globally we should now spend some time with a) the comments and b) trying to minimize code replication, especially in the testbenches (includes, macros, ...).

TheMightyDuckOfDoom self-assigned this

thommythomaso force-pushed the obi-tbenz branch 3 times, most recently from bf34134 to 895367b Compare

November 10, 2022 19:06

thommythomaso force-pushed the obi-tbenz branch 2 times, most recently from 53ef5f9 to d0c603c Compare

November 11, 2022 08:28


          multiprotocol iDMA: Add AXI Lite and OBI support

b9d7f04

thommythomaso force-pushed the obi-tbenz branch from d7d524c to b9d7f04 Compare

November 11, 2022 10:55

thommythomaso merged commit b9d7f04 into master

thommythomaso deleted the obi-tbenz branch

November 11, 2022 11:12

thommythomaso temporarily deployed to github-pages

November 11, 2022 11:14

Inactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels