Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Dockerfile #70

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add a Dockerfile #70

merged 1 commit into from
Sep 24, 2024

Conversation

gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented Sep 23, 2024

@himdel
Copy link
Collaborator

himdel commented Sep 23, 2024

Curious why is it needed to have a pulp-ui container running inside oci-env?
(As in, why not just run oci-env for pulp backend, and have the UI just proxy there?)

If you're copying the galaxy ui profile, I'm not sure anyone was using it, there may be skeletons there I don't know about :).

But, looks good as long as it still works 👍 :)

@gerrod3
Copy link
Contributor Author

gerrod3 commented Sep 23, 2024

Curious why is it needed to have a pulp-ui container running inside oci-env? (As in, why not just run oci-env for pulp backend, and have the UI just proxy there?)

The eventual goal is to have the UI also run in the same image of the Pulp backend, but I would like to get the node/npm depedencies inside the base Pulp image first. This is a temporary measure to help others on the Pulp team quickly setup the UI if they don't have node install on their system.

@himdel
Copy link
Collaborator

himdel commented Sep 23, 2024

Ah, makes sense :)

Looks like the Dockerfile should work, as long as it's run with a volume mounted in /pulp/app that points to pulp-ui/

@himdel himdel merged commit 1c8b91c into pulp:main Sep 24, 2024
2 checks passed
@gerrod3 gerrod3 deleted the dockerfile branch September 24, 2024 13:06
@mdellweg
Copy link
Member

Curious why is it needed to have a pulp-ui container running inside oci-env? (As in, why not just run oci-env for pulp backend, and have the UI just proxy there?)

The eventual goal is to have the UI also run in the same image of the Pulp backend, but I would like to get the node/npm depedencies inside the base Pulp image first. This is a temporary measure to help others on the Pulp team quickly setup the UI if they don't have node install on their system.

Honestly, I would prefer to not install node in the ci-container. It is still the base image for all the "production ready" containers we ship. And in production, you "just" want to serve some static files along with the API.

@gerrod3
Copy link
Contributor Author

gerrod3 commented Sep 27, 2024

Honestly, I would prefer to not install node in the ci-container. It is still the base image for all the "production ready" containers we ship. And in production, you "just" want to serve some static files along with the API.

Yes, after the UI meeting I am in agreement that we just want the images to serve the static files. I'll make the changes to the oci-images CI to build the files and copy them over to the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants