Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing of collections from git repos fails to clone any submodules #1065

Closed
dkliban opened this issue Jun 29, 2022 · 3 comments · Fixed by #1075
Closed

Syncing of collections from git repos fails to clone any submodules #1065

dkliban opened this issue Jun 29, 2022 · 3 comments · Fixed by #1075

Comments

@dkliban
Copy link
Member

dkliban commented Jun 29, 2022

test_sync_collection_from_git is failing because the pulp_installer collection now has a symlink to a file in the forklift submodule. The git remote needs to make sure that it also clones all submodules in a git repository.

dkliban added a commit to dkliban/pulp_ansible that referenced this issue Jun 29, 2022
dkliban added a commit to dkliban/pulp_ansible that referenced this issue Jun 29, 2022
@mdellweg
Copy link
Member

like git clone --recurse-submodules ?

@dkliban
Copy link
Member Author

dkliban commented Jun 30, 2022

@mdellweg exactly that. I was able to add that to the git clone command, but now it seems like galaxy-importer has a bug related to this also. When galaxy-importer extracts the collection into a temporary directory, it does not copy any of the submodules. As a result it still can't find the file being pointed to by a symlink[0].

[0] https://github.com/pulp/pulp_installer/blob/main/playbooks/resize_disk.yaml

@jctanner
Copy link
Contributor

jctanner commented Jun 30, 2022

This happens because the project's galaxy.yml has been configured to ignore the forklift directory at collection build time https://github.com/pulp/pulp_installer/blob/main/galaxy.yml#L88

More detail in https://issues.redhat.com/browse/AAH-1759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants