-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semantic_version says pre-release versions can be higher than release versions #1391
Labels
Comments
jctanner
added a commit
to jctanner/pulp_ansible
that referenced
this issue
Mar 9, 2023
…ns exist. fixes: pulp#1391 Signed-off-by: James Tanner <tanner.jc@gmail.com>
I did some experiment, and i cannot confirm the original claim that
I can however see, that in case we have "2.0.0" and "3.0.0-rc.1" we do not want to consider the latter as the
|
jctanner
added a commit
to jctanner/pulp_ansible
that referenced
this issue
Mar 15, 2023
fixes: pulp#1391 Signed-off-by: James Tanner <tanner.jc@gmail.com>
jctanner
added a commit
to jctanner/pulp_ansible
that referenced
this issue
Mar 15, 2023
…re-releases exist. fixes: pulp#1391 Signed-off-by: James Tanner <tanner.jc@gmail.com>
jctanner
added a commit
to jctanner/pulp_ansible
that referenced
this issue
Mar 17, 2023
fixes: pulp#1391 Signed-off-by: James Tanner <tanner.jc@gmail.com>
jctanner
added a commit
to jctanner/pulp_ansible
that referenced
this issue
Mar 17, 2023
fixes: pulp#1391 Signed-off-by: James Tanner <tanner.jc@gmail.com>
jctanner
added a commit
to jctanner/pulp_ansible
that referenced
this issue
Mar 17, 2023
jctanner
added a commit
to jctanner/pulp_ansible
that referenced
this issue
Mar 17, 2023
jctanner
added a commit
to jctanner/pulp_ansible
that referenced
this issue
Mar 20, 2023
jctanner
added a commit
to jctanner/pulp_ansible
that referenced
this issue
Mar 20, 2023
jctanner
added a commit
to jctanner/pulp_ansible
that referenced
this issue
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
main
Describe the bug
semantic_version says "2.0.1-rc1" is greater than "1.0.1", which is perhaps true per the spec but I think we collectively think otherwise.
To Reproduce
Expected behavior
Pre-release versions should only get marked as is_highest when no stable releases exist.
The text was updated successfully, but these errors were encountered: