Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync can fail if the namespace avatar failed to be downloaded. #1868

Closed
gerrod3 opened this issue May 29, 2024 · 0 comments · Fixed by #1869
Closed

Sync can fail if the namespace avatar failed to be downloaded. #1868

gerrod3 opened this issue May 29, 2024 · 0 comments · Fixed by #1869
Labels
Issue Triage-Needed

Comments

@gerrod3
Copy link
Contributor

gerrod3 commented May 29, 2024

Version
latest, 0.21, 0.20

Describe the bug
When performing a sync if an namespace avatar fails to download, the avatar should be set to null so that a future sync will retry. However, our code to properly null the artifact download causes the sync to fail with 'NoneType' object is not iterable. We need to set d_artifacts to an empty list, not None.

https://github.com/pulp/pulp_ansible/blob/main/pulp_ansible/app/tasks/collections.py#L1157-L1162

JIRA: https://issues.redhat.com/browse/AAH-3218
gerrod3 added a commit to gerrod3/pulp_ansible that referenced this issue May 29, 2024
@gerrod3
Fix sync on failed namespace avatar downloads
cf895e5 
fixes: pulp#1868
@gerrod3 gerrod3 mentioned this issue May 29, 2024
Merged
mdellweg pushed a commit that referenced this issue May 29, 2024
@gerrod3 @mdellweg
Fix sync on failed namespace avatar downloads
2f09460 
fixes: #1868
patchback bot pushed a commit that referenced this issue May 29, 2024
@gerrod3 @patchback
Fix sync on failed namespace avatar downloads
99105a3 
fixes: #1868
(cherry picked from commit 2f09460)
@patchback patchback bot mentioned this issue May 29, 2024
Merged
patchback bot pushed a commit that referenced this issue May 29, 2024
@gerrod3 @patchback
Fix sync on failed namespace avatar downloads
83a6365 
fixes: #1868
(cherry picked from commit 2f09460)
@patchback patchback bot mentioned this issue May 29, 2024
Merged
mdellweg pushed a commit that referenced this issue May 29, 2024
@gerrod3 @mdellweg
Fix sync on failed namespace avatar downloads
b0cc046 
fixes: #1868
(cherry picked from commit 2f09460)
mdellweg pushed a commit that referenced this issue May 29, 2024
@gerrod3 @mdellweg
Fix sync on failed namespace avatar downloads
f37706b 
fixes: #1868
(cherry picked from commit 2f09460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue Triage-Needed
Projects
No open projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sync on failed namespace avatar downloads gerrod3/pulp_ansible
1 participant
@gerrod3