Fix wrong version ordering in x-repo search

[jerabekjiri]

fix: #1516

AAH issue: AAH-2581

[jerabekjiri]

@mdellweg would it be better to add the SemanticVersionOrderingFilter to pulpcore instead of pulp_ansible?

[mdellweg]

@mdellweg would it be better to add the SemanticVersionOrderingFilter to pulpcore instead of pulp_ansible?

No, let's keep it here for. I think this is not the last iteration of it. Looks a bit naive to me. Are any letters allowed in ansible collection versions? How does it react to "1.0.0-beta"?
I would love to see some domain specific PostgresQL version-fields however, eventually.

[jerabekjiri]

@mdellweg

Are any letters allowed in ansible collection versions? How does it react to "1.0.0-beta"?

good point. I checked and yes, they are allowed. We can theoretically have versions like 1.0.0-beta or 1.0.0-rc. So my solution doesn't really solve it, I can remove letters with regex for example, but then again sorting will be wrong.

[jerabekjiri]

As you mentioned, the best solution might be to add the version field directly in PostgreSQL https://github.com/theory/pg-semver/ https://pgxn.org/dist/semver/doc/semver.html

[jerabekjiri]

David told me about version_major, version_minor, version_patch, version_prerelease fields which I unfortunately missed. However, there is still an issue with 1.0.0-beta and 1.0.0-rc.

this is correct, but sorts pre-released version incorrectly:

"0.9.0",
"1.7.3",
"1.22.3-beta",
"1.22.3-alpha",
"1.22.3",

reversed order sorts pre-released correctly, but is wrong

"0.9.0",
"1.7.3",
"1.22.3",
"1.22.3-alpha",
"1.22.3-beta",

[jerabekjiri]

Updated sorting, now the sorting works correctly even with the prerelease part.

/search/collection-versions/?order_by=-version:
"1.22.2",
"1.22.2-beta",
"1.22.1",
"1.22.1-rc",
"1.22.1-beta",
"1.22.1-alpha",
"1.7.3",
"1.0.0"

[jctanner]

Can you enable postgres debug logging and show us the raw sql this annotation is adding to the query?

[jerabekjiri]

@jctanner hmm... for some reason the annotated field prerelease show as 9 ( oh, I think 9 is the position of prerelease field)

 ORDER BY "ansible_collectionversion"."version_major" ASC,
          "ansible_collectionversion"."version_minor" ASC,
          "ansible_collectionversion"."version_patch" ASC,
          9 ASC

https://gist.github.com/jerabekjiri/8eb71d6e0764f8761e5443df53b6440e

[jctanner]

Seems fine, but it needs a functional test.

[mdellweg]

Looks like these happen to be alright in alphabetical order.

[mdellweg]

What is this change doing?

[jerabekjiri]

Well, since we have a custom SemanticVersionOrderingFilter, we don't want this incorrect sorting by collection version.

[mdellweg]

right, now that i can see it on the large screen...

[mdellweg]

right, now that i can see it on the large screen...