Activate streaming from object storage #944
Conversation
mdellweg
force-pushed
the
stream
branch
3 times, most recently
from
b16d9b2
to
5ed7c75
Compare
| with open(local_temp_file.name) as file_handle: | ||
| importer_result = process_collection( | ||
| file_handle, filename=filename, logger=user_facing_logger | ||
| ) |
There was a problem hiding this comment.
This is a hell of a workaround to prevent galaxy-importer to try to be clever.
There was a problem hiding this comment.
haha. we may have had a reason for this originally, but if we are able to get it working with pulp_ansible passing a file handle to galaxy-importer, then +1 to that
|
I intend to solve the issue on the galaxy-importer side. |
mdellweg
force-pushed
the
stream
branch
4 times, most recently
from
c5741c1
to
d768806
Compare
|
Hello @mdellweg! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-05-18 12:26:27 UTC |
| if ( | ||
| settings.DEFAULT_FILE_STORAGE == "pulpcore.app.models.storage.FileSystem" | ||
| or not settings.REDIRECT_TO_OBJECT_STORAGE | ||
| ): |
| @@ -1,6 +1,6 @@ | |||
| aiofiles>=0.8.0 | |||
| async_lru~=1.0 | |||
| galaxy_importer>=0.4.1 | |||
| galaxy_importer>=0.4.5 | |||
There was a problem hiding this comment.
their release failed: https://github.com/ansible/galaxy-importer/runs/6479389918?check_suite_focus=true
There was a problem hiding this comment.
galaxy-importer 0.4.5 is now on pypi
fixes #493