Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Fixing CI issues #415

Merged
merged 4 commits into from
Sep 2, 2020
Merged

Fixing CI issues #415

merged 4 commits into from
Sep 2, 2020

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Aug 31, 2020

@pulpbot
Copy link
Member

pulpbot commented Aug 31, 2020

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@fao89 fao89 force-pushed the fix_ci_issue branch 6 times, most recently from ca49118 to 6f4811e Compare August 31, 2020 21:42
@mdellweg
Copy link
Member

mdellweg commented Sep 1, 2020

If you'd separate them, i'd be happy to merge the solution to the setuptools problem.

@fao89
Copy link
Member Author

fao89 commented Sep 1, 2020

If you'd separate them, i'd be happy to merge the solution to the setuptools problem.

I was hoping to get the solution for both of them, but the podman one is tough.
I will split the PR

@mdellweg
Copy link
Member

mdellweg commented Sep 1, 2020

Splitting them is good, but i have the podman on dedian10 solution ready for you:
fao89#1

@fao89 fao89 force-pushed the fix_ci_issue branch 3 times, most recently from 30faa59 to 6ce4b6b Compare September 1, 2020 19:26
name: virtualenvwrapper
state: present
virtualenv: '{{ pulp_install_dir }}'
virtualenv_command: '{{ pulp_python_interpreter }} -m venv'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should copy the "when" from the task below it.

@fao89 fao89 marked this pull request as ready for review September 1, 2020 21:09
@@ -43,18 +43,9 @@
- nc
- python-django-bash-completion
- python3-setuptools
- python3-virtualenv-clone
Copy link
Member

@mikedep333 mikedep333 Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to have this code cleanup! 😎

Comment on lines +148 to +149
environment:
SETUPTOOLS_USE_DISTUTILS: stdlib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the commit message and I understand why we are doing this, but I really want a comment above this line.

@dkliban dkliban merged commit 9957646 into pulp:master Sep 2, 2020
@@ -49,6 +49,7 @@
- name: Install Inspec (yum)
yum:
name: "{{ inspec_download_source_dir }}/{{ inspec_download_url.split('/')[-1] }}"
disable_gpg_check: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

apt:
name:
- libseccomp2=2.4*
default_release: buster-backports
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants