-
Notifications
You must be signed in to change notification settings - Fork 81
Conversation
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
ca49118
to
6f4811e
Compare
If you'd separate them, i'd be happy to merge the solution to the setuptools problem. |
I was hoping to get the solution for both of them, but the podman one is tough. |
Splitting them is good, but i have the podman on dedian10 solution ready for you: |
30faa59
to
6ce4b6b
Compare
name: virtualenvwrapper | ||
state: present | ||
virtualenv: '{{ pulp_install_dir }}' | ||
virtualenv_command: '{{ pulp_python_interpreter }} -m venv' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should copy the "when" from the task below it.
[noissue]
@@ -43,18 +43,9 @@ | |||
- nc | |||
- python-django-bash-completion | |||
- python3-setuptools | |||
- python3-virtualenv-clone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to have this code cleanup! 😎
environment: | ||
SETUPTOOLS_USE_DISTUTILS: stdlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the commit message and I understand why we are doing this, but I really want a comment above this line.
@@ -49,6 +49,7 @@ | |||
- name: Install Inspec (yum) | |||
yum: | |||
name: "{{ inspec_download_source_dir }}/{{ inspec_download_url.split('/')[-1] }}" | |||
disable_gpg_check: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!
apt: | ||
name: | ||
- libseccomp2=2.4* | ||
default_release: buster-backports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
[noissue]