Refactor commonHandler.js tests

jest.config.js

@@ -28,7 +28,7 @@ const config = {
       setupFilesAfterEnv: ["<rootDir>/test/global.setup.jest.js"],
       testMatch: [
         "<rootDir>/test/*.unit.test.js",
-        "<rootDir>/test/handlers/**/**.js",
+        "<rootDir>/test/handlers/**/**.test.js",
       ],
     },
     {

test/handlers/common_handler/auth_fail.test.js

@@ -0,0 +1,54 @@
+const common = require("../../../src/handlers/common_handler.js");
+const { Res, Req } = require("./express_fakes.js");
+
+describe("Modifies res when invoking 'missingAuthJSON'", () => {
+
+  let EXPECTED_MESSAGE = "Requires authentication. Please update your token if you haven't done so recently.";
+  let EXPECTED_STATUS = 401;
+
+  test("via Bad Auth", async () => {
+    let res = new Res();
+    let req = new Req();
+
+    await common.authFail(req, res, { short: "Bad Auth" }, 0);
+
+    expect(res.statusCode).toBe(EXPECTED_STATUS);
+    expect(res.JSONObj.message).toBe(EXPECTED_MESSAGE);
+  });
+
+  test("via Auth Fail", async () => {
+    let res = new Res();
+    let req = new Req();
+
+    await common.authFail(req, res, { short: "Auth Fail" }, 0);
+
+    expect(res.statusCode).toBe(EXPECTED_STATUS);
+    expect(res.JSONObj.message).toBe(EXPECTED_MESSAGE);
+  });
+
+  test("via No Repo Access", async () => {
+    let res = new Res();
+    let req = new Req();
+
+    await common.authFail(req, res, { short: "No Repo Access" }, 0);
+
+    expect(res.statusCode).toBe(EXPECTED_STATUS);
+    expect(res.JSONObj.message).toBe(EXPECTED_MESSAGE);
+  });
+});
+
+describe("Modifies res when invoking serverError", () => {
+
+  let EXPECTED_STATUS = 500;
+  let EXPECTED_MESSAGE = "Application Error";
+
+  test("via DEFAULT", async () => {
+    let res = new Res();
+    let req = new Req();
+
+    await common.authFail(req, res, { short: "NOT_A_VALID_OPTION" }, 0);
+
+    expect(res.statusCode).toBe(EXPECTED_STATUS);
+    expect(res.JSONObj.message).toBe(EXPECTED_MESSAGE);
+  });
+});

test/handlers/common_handler/bad_package_json.test.js

@@ -0,0 +1,27 @@
+const common = require("../../../src/handlers/common_handler.js");
+const { Res, Req } = require("./express_fakes.js");
+
+const EXPECTED_MESSAGE = "The package.json at owner/repo isn't valid.";
+const EXPECTED_STATUS = 400;
+
+test("Modifies res when invoked directly", async () => {
+  let res = new Res();
+  let req = new Req();
+
+  await common.badPackageJSON(req, res);
+
+  expect(res.statusCode).toBe(EXPECTED_STATUS);
+  expect(res.JSONObj.message).toBe(EXPECTED_MESSAGE);
+});
+
+test("Modifies res when invoked indirectly", async () => {
+  let res = new Res();
+  let req = new Req();
+
+  await common.handleError(req, res, {
+    short: "Bad Package"
+  });
+
+  expect(res.statusCode).toBe(EXPECTED_STATUS);
+  expect(res.JSONObj.message).toBe(EXPECTED_MESSAGE);
+});

test/handlers/common_handler/bad_repo_json.test.js

@@ -0,0 +1,27 @@
+const common = require("../../../src/handlers/common_handler.js");
+const { Res, Req } = require("./express_fakes.js");
+
+const EXPECTED_MESSAGE = "That repo does not exist, isn't an atom package, or atombot does not have access.";
+const EXPECTED_STATUS = 400;
+
+test("Modifies res when invoked directly", async () => {
+  let res = new Res();
+  let req = new Req();
+
+  await common.badRepoJSON(req, res);
+
+  expect(res.statusCode).toBe(EXPECTED_STATUS);
+  expect(res.JSONObj.message).toBe(EXPECTED_MESSAGE);
+});
+
+test("Modifies res when invoked indirectly", async () => {
+  let res = new Res();
+  let req = new Req();
+
+  await common.handleError(req, res, {
+    short: "Bad Repo"
+  });
+
+  expect(res.statusCode).toBe(EXPECTED_STATUS);
+  expect(res.JSONObj.message).toBe(EXPECTED_MESSAGE);
+});

test/handlers/common_handler/express_fakes.js

@@ -0,0 +1,29 @@
+// This is an impersonator of the ExpressJS Response Object.
+// Who's goal is to very simply test the exact features we care about.
+// Without overhead or bloat.
+class Res {
+  constructor() {
+    this.statusCode = 0;
+    this.JSONObj = "";
+  }
+  json(obj) {
+    this.JSONObj = obj;
+    return this;
+  }
+  status(code) {
+    this.statusCode = code;
+    return this;
+  }
+}
+
+class Req {
+  constructor() {
+    this.ip = "0.0.0.0";
+    this.method = "TEST";
+    this.url = "/dev";
+    this.protocol = "DEV";
+    this.start = Date.now();
+  }
+}
+
+module.exports = { Res, Req };