Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Actions: 2024 - January 30 #239

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Admin Actions: 2024 - January 30 #239

merged 7 commits into from
Jan 31, 2024

Conversation

confused-Techie
Copy link
Member

Requirements

  • Filling out the template is required.

  • All new code requires tests to ensure against regressions.

    • However, if your PR contains zero code changes, feel free to select the checkmark below to indicate so.
  • Have you ran tests against this code?

  • This PR contains zero code changes.

Description of the Change

This PR adds new admin actions that have occurred.

Additionally, this PR defines the Bundled badge spec which is being linked to when visiting bundled packages in the PPR.
Also this PR adds a new key to the badge specification of alt. This key useful only when a badge is Deprecated can be used to add the name of the new package that's recommended to install. This may prove to be useful if we want to help users navigate to the new package easier than having to visit the link, read the admin actions, and find the link to the new package manually.

In the future we may want to investigate if we add this logic automatically to the frontend, to help link to these packages.

Copy link
Member

@Daeraxa Daeraxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this was mostly a single typo that got copied a whole bunch of times. Otherwise seems good to me.

docs/reference/Admin_Actions.md Outdated Show resolved Hide resolved
docs/reference/Admin_Actions.md Outdated Show resolved Hide resolved
docs/reference/Admin_Actions.md Outdated Show resolved Hide resolved
docs/reference/Admin_Actions.md Outdated Show resolved Hide resolved
docs/reference/Admin_Actions.md Outdated Show resolved Hide resolved
docs/reference/Admin_Actions.md Outdated Show resolved Hide resolved
confused-Techie and others added 6 commits January 30, 2024 19:51
Co-authored-by: Daeraxa <58074586+Daeraxa@users.noreply.github.com>
Co-authored-by: Daeraxa <58074586+Daeraxa@users.noreply.github.com>
Co-authored-by: Daeraxa <58074586+Daeraxa@users.noreply.github.com>
Co-authored-by: Daeraxa <58074586+Daeraxa@users.noreply.github.com>
Co-authored-by: Daeraxa <58074586+Daeraxa@users.noreply.github.com>
Co-authored-by: Daeraxa <58074586+Daeraxa@users.noreply.github.com>
@confused-Techie
Copy link
Member Author

Thanks for the review @Daeraxa just merged your grammar fixes, absolutely copy and pasted those from other identical situations, so makes sense my bad spelling propagated lol

@confused-Techie confused-Techie merged commit 4726b53 into main Jan 31, 2024
6 checks passed
@confused-Techie confused-Techie deleted the admin-actions branch January 31, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants