cache message formatters

pulsar-edit · Apr 1, 2023 · c7b5d7c · c7b5d7c
1 parent 0030680
commit c7b5d7c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/src/i18n-helpers.js b/src/i18n-helpers.js
@@ -140,5 +140,6 @@ module.exports = {
   I18nCacheHelper,
   walkStrings,
   travelDownObjectPath,
-  optionalTravelDownObjectPath
+  optionalTravelDownObjectPath,
+  travelDownOrMakePath
 };
diff --git a/src/i18n.js b/src/i18n.js
@@ -6,7 +6,8 @@ const {
   I18nCacheHelper,
   walkStrings,
   travelDownObjectPath,
-  optionalTravelDownObjectPath
+  optionalTravelDownObjectPath,
+  travelDownOrMakePath
 } = require("./i18n-helpers");
 
 class I18n {
@@ -215,9 +216,18 @@ class I18n {
    * formats a string with opts,
    * and caches the message formatter for the provided path.
    */
-  format(ns, path, str, lang, opts) {
-    let ast = this.cacheHelper.fetchAST(ns, path, str, lang);
+  format(ns, _path, str, lang, opts) {
+    let path = [ns, lang, ..._path];
+
+    let cachedFormatter = optionalTravelDownObjectPath(this.cachedFormatters, path);
+    if (cachedFormatter) return cachedFormatter.format(opts);
+
+    let ast = this.cacheHelper.fetchAST(ns, _path, str, lang);
     let formatter = new IntlMessageFormat(ast, lang);
+
+    let last = path.pop();
+    let cachePath = travelDownOrMakePath(this.cachedFormatters, path);
+    cachePath[last] = formatter;
     return formatter.format(opts);
   }
 }