Implementing folds for new tree-sitter #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
So I won't pretend to fully understand every aspect of the code being used here.
But overall the code looks solid from a conventions standpoint, and am trusting you're testing it well.
Huge and appreciated effort here, just added a few comments to clean up in some small places.
Otherwise the tests:
- Editor tests on macOS is receiving 5 failures while we expect 0
- find-and-replace: 57 Failures, within the expected range
- symbols-view: 4 failures, but we expect only 2 failures (unsure why those would be failing here tbh)
- tree-view: 2 Failures, within the expected range
- Codacy Static Code Analysis has failed, but it seems it failed to properly analyze the commit, rather than any issues with it. So this can be ignored.
Otherwise this totally gets a lite approval from me, even though I'd like to read more and understand better what everything is doing here. But short of that happening I'm approving this getting merged.
Co-authored-by: confused_techie <dev@lhbasics.com>
…r into wasm-tree-sitter-folds
|
@confused-Techie |
|
I'll address the test failures on branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like it says on the title.
Tree-sitter, originally, have no implementation of folding. I basically copied this code from the NeoVIM implementation, which seems to be the most advanced on this implementation.