Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this PR is a bit of a smaller one, some simple decaf work for the package
wrap-guide
.As always this PR is targeting a branch
wrap-guide-decaf
that has been machine decaffed for easier review.If this PR is accepted, prior to being merged, the target branch will change to main and will be merged into the editor.
Please feel free to provide any feedback!
A few notes here, some of the awkward return function patterns were left in to be reworked later in a more focused PR, since they do work, and the fix isn't immediately known. Additionally within
wrap-guide-element.js
on Line 32, there is aTODO
once it's converted to JavaScript. I'll take a further look, since I'm unsure of which portion should be changed, but I'm assuming it's the API call itself togetNextUpdatePromise()
but will try to investigate further later on.