remove weird duplicate accented fixture file (hopefully?) #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Package that this change is concerned, |
|
@meadowsys would be nice to see all tests happy here, even if the chance of them being affected is super super slim. |
confused-Techie
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Alright, now that all tests have successfully run, here's what we are looking at:
find-and-replace: ✅ 37 Failuressettings-view: ✅ 2 Failures (While some PRs have fixes for this, they have not yet been merged)symbols-view: ✅ 2 Failurestree-view: ✅ 2 Failures
So with that said, and the diff here being literally deleting a single duplicated file, I fully support this PR being merged, and we should be good to go
|
oki! going to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been two fixture files for
markdown-previewthat both look likeáccéntéd.md, where the second one appears to have been introduced accidentally in this PR commit (thanks @DeeDeeG for finding it). Tried to remove the right one, checked it a few times, I think I got the right one? lets see how the tests go >w<