return a warning instead of an error on login failure #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
approved these changes
Jan 24, 2024
Aparently `pulumi login` can fail, and yet other pulumi commands that follow can succeed (see #1081). Instead of failing outright when login fails, just print a warning, so people are not confused when further errors happen later.
tgummerer
force-pushed
the
login-warning-only
branch
from
169de4b
to
73f904f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aparently
pulumi logincan fail, and yet other pulumi commands that follow can succeed (see #1081).Instead of failing outright when login fails, just print a warning, so people are not confused when further errors happen later.
Fixes #1081