fix: remove pulumi-version default
#1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value is conflicting with the new `pulumi-version-file` option. Also, we are defaulting the version in the code here, so we don't need the default to be set by the action. https://github.com/pulumi/actions/blob/19cc848d9c6fb4ac618050ff0ab3272d1ddec7b4/src/config.ts#L44
justinvp
approved these changes
Jun 25, 2024
corymhall
added a commit
that referenced
this pull request
Jun 25, 2024
update the changelog for a minor release including #1208
corymhall
added a commit
that referenced
this pull request
Jun 25, 2024
update the changelog for a minor release including #1208
This was referenced Jun 26, 2024
Merged
This was referenced Jul 26, 2024
Merged
This was referenced Aug 23, 2024
Merged
Merged
This was referenced Sep 28, 2024
This was referenced Sep 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value is conflicting with the new
pulumi-version-fileoption. Also, we are defaulting the version in the code here, so we don't need the default to be set by the action.actions/src/config.ts
Line 44 in 19cc848