Remove ansi control chars from PR comment message

README.md

@@ -87,9 +87,6 @@ The action can be configured with the following arguments:
   `true`. This is in an effort to reduce verbosity - if you want to have a
   comment per PR run, please ensure that you set this to `false`.
 
-- `comment-max-character` - (optional) Maximum number of characters of the Pulumi
-  action result to be added to the PR. Default value is 64000.
-
 - `expect-no-changes` - (optional) Return an error if any changes occur during
   this update.
 

action.yml

@@ -32,10 +32,6 @@ inputs:
     description: 'If true, a comment on the GitHub step summary will be created'
     required: false
     default: 'false'
-  comment-max-character:
-    description: 'Maximum number of characters of output added to the PR.'
-    required: false
-    default: "64000"
   github-token:
     description: 'Github Token'
     required: false

src/__tests__/config.test.ts

@@ -9,7 +9,6 @@ const defaultConfig: Record<string, string> = {
   'pulumi-version': '^3',
   'comment-on-pr': 'false',
   'comment-on-summary': 'false',
-  'comment-max-character': '64000',
   upsert: 'false',
   remove: 'false',
   refresh: 'false',
@@ -42,7 +41,6 @@ describe('config.ts', () => {
       Object {
         "cloudUrl": "file://~",
         "command": "up",
-        "commentMaxCharacter": 64000,
         "commentOnPr": false,
         "commentOnPrNumber": undefined,
         "commentOnSummary": false,

src/config.ts

@@ -84,7 +84,6 @@ export function makeConfig() {
     commentOnPr: getBooleanInput('comment-on-pr'),
     commentOnPrNumber: getNumberInput('comment-on-pr-number', {}),
     commentOnSummary: getBooleanInput('comment-on-summary'),
-    commentMaxCharacter: getNumberInput('comment-max-character'),
     upsert: getBooleanInput('upsert'),
     remove: getBooleanInput('remove'),
     refresh: getBooleanInput('refresh'),

src/libs/__tests__/pr.test.ts

@@ -13,7 +13,6 @@ const projectName = 'myFirstProject';
 const defaultOptions = {
   command: 'preview',
   stackName: 'staging',
-  commentMaxCharacter: 64000,
   options: {},
 } as Config;
 const createComment = jest.fn();
@@ -56,7 +55,7 @@ describe('pr.ts', () => {
     });
   });
 
-  it('should convert ansi controll character to html and add to pull request message', async () => {
+  it('should convert ansi control character to html and add to pull request message', async () => {
     // @ts-ignore
     gh.context = {
       payload: {

src/libs/pr.ts

@@ -46,14 +46,16 @@ export async function handlePullRequestMessage(
     command,
     stackName,
     editCommentOnPr,
-    commentMaxCharacter,
   } = config;
 
+  // GitHub limits comment characters to 65535, use lower max to keep buffer for variable values
+  const MAX_CHARACTER_COMMENT = 64_000;
+
   const heading = `#### :tropical_drink: \`${command}\` on ${projectName}/${stackName}`;
 
   const summary = '<summary>Pulumi report</summary>';
 
-  const [htmlBody, trimmed]: [string, boolean] = ansiToHtml(output, commentMaxCharacter);
+  const [htmlBody, trimmed]: [string, boolean] = ansiToHtml(output, MAX_CHARACTER_COMMENT);
 
   const body = dedent`
     ${heading}