Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to fixup bridge imports #1103

Merged
merged 11 commits into from
Nov 7, 2024
Merged

Migration to fixup bridge imports #1103

merged 11 commits into from
Nov 7, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Oct 15, 2024

Supersedes pulumi/pulumi-upgrade-provider-action#34.

Adds a migration to update imports to point at new paths introduced by pulumi/pulumi-terraform-bridge#2480 (after that's released).

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets give it a shot.

@danielrbradley
Copy link
Member

Happy with this in principle.

Have you tested this on a handful of providers locally already?

We should probably have a way of tracking a migration roll-out and flagging any issues.

@blampe
Copy link
Contributor Author

blampe commented Nov 7, 2024

Have you tested this on a handful of providers locally already?

Tested locally as well as on pulumi/pulumi-gcp#2593 pulumi/pulumi-datadog#683 pulumi/pulumi-cloudflare#955 pulumi/pulumi-random#1345 (I also tried AWS a few times before realizing Anton had already migrated it :)).

We should probably have a way of tracking a migration roll-out and flagging any issues.

@danielrbradley not sure if there's a better way to track, but there are currently 34 uses of the deprecated pf module which we expect to go to zero. I can kick off an "update workflows" actions and then see where things stand after those PRs have had a chance to merge.
https://github.com/search?q=org%3Apulumi+path%3Ago.mod+%22github.com%2Fpulumi%2Fpulumi-terraform-bridge%2Fpf+%22&type=code

@blampe blampe added this pull request to the merge queue Nov 7, 2024
Merged via the queue into master with commit 508c3b7 Nov 7, 2024
7 checks passed
@blampe blampe deleted the blampe/patch-imports branch November 7, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants