Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for null provider #505

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Fixes for null provider #505

merged 4 commits into from
Aug 4, 2023

Conversation

ringods
Copy link
Member

@ringods ringods commented Aug 4, 2023

Submitting the work of #504 without the version update.

Updates:

  • List more of the need build tools
  • Removes a duplicate build dependency
  • Fixes the build+lint of the null provider files

t0yv0
t0yv0 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

@ringods ringods merged commit c738d53 into master Aug 4, 2023
@ringods ringods deleted the fixes-for-null-provider branch August 4, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwahbe iwahbe iwahbe approved these changes

@t0yv0 t0yv0 t0yv0 approved these changes

@danielrbradley danielrbradley Awaiting requested review from danielrbradley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ringods @t0yv0 @iwahbe