Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for AssumeRoleWithWebIdentity #2252

Closed
MMartyn opened this issue Dec 7, 2022 · 1 comment · Fixed by #3084
Closed

Support for AssumeRoleWithWebIdentity #2252

MMartyn opened this issue Dec 7, 2022 · 1 comment · Fixed by #3084
Assignees
@thomas11
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).

Comments

@MMartyn
Copy link

MMartyn commented Dec 7, 2022

What happened?

The credential validation that is currently in here doesn't handle AssumeRoleWithWebIdentity. So if you use AssumeRoleWithWebIdentity then you currently need to skip the validation checks.

Steps to reproduce

Attempt to use AssumeRoleWithWebIdentity

Expected Behavior

It to seemlessly work regardless of if you are using keys, roles, or web identities.

Actual Behavior

You get an error saying that the credentials couldn't be validated.

Output of pulumi about

No response

Additional context

Relevant code:
https://github.com/hashicorp/terraform-provider-aws/blob/46dbaeb5a40328b9a5200de13fa842700c5a1a35/internal/provider/provider.go#L2316
https://github.com/pulumi/pulumi-aws/blob/master/provider/resources.go#L340

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@MMartyn MMartyn added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Dec 7, 2022
@roothorp
Copy link
Contributor

roothorp commented Dec 8, 2022 •
edited
Loading

Hi @MMartyn, thanks for the issue! I've raised this with the team to be prioritized and added to our work stack.

I assume this will be implemented in a similar way to our current implementation of AssumeRole.

@roothorp roothorp added impact/usability Something that impacts users' ability to use the product easily and intuitively size/S Estimated effort to complete (1-2 days). and removed needs-triage Needs attention from the triage team labels Dec 8, 2022
thomas11 added a commit that referenced this issue Dec 3, 2023
@thomas11
Add assumeRoleWithWebIdentity to creds validation #2252
3fada59
thomas11 added a commit that referenced this issue Dec 4, 2023
@thomas11
Add assumeRoleWithWebIdentity to creds validation #2252
a6bfb10
@thomas11 thomas11 mentioned this issue Dec 4, 2023
Merged
thomas11 added a commit that referenced this issue Dec 4, 2023
@thomas11
Add assumeRoleWithWebIdentity to creds validation #2252
9bdb37b
thomas11 added a commit that referenced this issue Dec 5, 2023
@thomas11
Add assumeRoleWithWebIdentity to creds validation #2252
bfa57be
thomas11 added a commit that referenced this issue Dec 6, 2023
@thomas11
Add assume role with web identity, expand assume role properties in c…
1083a8b 
…reds validation (#3084)

- Add `assumeRoleWithWebIdentity` to creds validation #2252
- Add most missing properties to assumeRole credentials check
- Add duration to supported assumeRole properties

Resolves ##2252

The supported properties of both `assumeRole` and
`assumeRoleWithWebIdentity` should now match [the ones documented in the
registry](https://www.pulumi.com/registry/packages/aws/installation-configuration/#configuration-options).
@thomas11 thomas11 self-assigned this Dec 6, 2023
@thomas11 thomas11 linked a pull request Dec 6, 2023 that will close this issue
Add assume role with web identity, expand assume role properties in creds validation #3084
Merged
@thomas11 thomas11 added the resolution/fixed This issue was fixed label Dec 6, 2023
@thomas11 thomas11 closed this as completed Dec 6, 2023
thomas11 added a commit that referenced this issue Dec 6, 2023
@thomas11
Add assumeRoleWithWebIdentity to creds validation #2252
82338bd
thomas11 added a commit that referenced this issue Dec 19, 2023
@thomas11
Add assumeRoleWithWebIdentity to creds validation #2252
8a772e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomas11 thomas11

Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Projects
None yet
Milestone
No milestone
3 participants
@thomas11 @MMartyn @roothorp