-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pulumi/pulumi-aws version to 6.57.0 #1414
Conversation
@@ -130,8 +131,13 @@ export interface EC2ServiceArgs { | |||
* Whether to enable Amazon ECS Exec for the tasks within the service. | |||
*/ | |||
enableExecuteCommand?: pulumi.Input<boolean>; | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused here, are automatically computing the AWSX schema based on the AWS schema it seems?
EC2ServiceArgs looks auto-generated in awsx/schema-types.ts
This looks benign but is good to know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we ref types from the aws schema in the awsx schema. And we select the provider version for the schema based on the contents of package.json
:
pulumi-awsx/schemagen/pkg/gen/schema.go
Line 38 in bef262a
awsSpec := getPackageSpec("aws", dependencies.Aws) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm. We might be cloning the type contents instead of referencing types via schema references, but looks intentional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you're right, should've been more specific. We're copying certain types and properties from the aws schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has been shipped in release v2.17.0. |
Update pulumi/pulumi-aws version to 6.57.0
Fixes #1386