Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pulumi/pulumi-aws version to 6.57.0 #1414

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

pulumi-bot
Copy link
Contributor

@pulumi-bot pulumi-bot commented Nov 6, 2024

Update pulumi/pulumi-aws version to 6.57.0

Fixes #1386

@t0yv0 t0yv0 self-requested a review November 6, 2024 15:52
@@ -130,8 +131,13 @@ export interface EC2ServiceArgs {
* Whether to enable Amazon ECS Exec for the tasks within the service.
*/
enableExecuteCommand?: pulumi.Input<boolean>;
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused here, are automatically computing the AWSX schema based on the AWS schema it seems?

EC2ServiceArgs looks auto-generated in awsx/schema-types.ts

This looks benign but is good to know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we ref types from the aws schema in the awsx schema. And we select the provider version for the schema based on the contents of package.json:

awsSpec := getPackageSpec("aws", dependencies.Aws)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm. We might be cloning the type contents instead of referencing types via schema references, but looks intentional

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you're right, should've been more specific. We're copying certain types and properties from the aws schema

@t0yv0 t0yv0 requested review from flostadler and corymhall November 6, 2024 15:57
Copy link
Contributor

@flostadler flostadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t0yv0 t0yv0 merged commit b424d04 into master Nov 6, 2024
9 of 10 checks passed
@t0yv0 t0yv0 deleted the update-pulumi-aws/6.57.0-11706680146-14 branch November 6, 2024 16:42
@pulumi-bot
Copy link
Contributor Author

This PR has been shipped in release v2.17.0.

@pulumi-bot pulumi-bot mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permanent diff
3 participants