Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken tests #449

Merged
merged 6 commits into from
May 11, 2023
Merged

Fix broken tests #449

merged 6 commits into from
May 11, 2023

Conversation

rquitales
Copy link
Member

@rquitales rquitales commented May 11, 2023 •
edited
Loading

This PR addresses 3 outstanding issues with the current broken tests:

  1. Pulumi Yaml Program test is flakey as specs within it interact with ConfigMaps of the same name. We can run this sequentially, but I've fixed this by dynamically generating the require Pulumi Program CRs and randomising ConfigMap names.
  2. The stale state test is flakey and needs to be run sequentially by decorating it with Gingko's Ordered decorator.
  3. Usage of pulumi-kubernetes is pinned to v3.26.0 of the provider. v3.27.0 was recently released and caused our previously passing tests to fail (see run history for this commit). v3.27.0 switched to using foreground cascading deletion, which is causing our stacks to fail deletion on finalization. I'm pinning to v3.26.0 for now to unblock CI and releases, until we can determine a better solution going forwards.

rquitales added 6 commits May 10, 2023 20:57
@rquitales
Refactor tests
f1b06e0
@rquitales
Ensure that program test is parallelisable
c4f8cbc 
Dynamically generate the ConfigMaps with random names so we do not
have spec pollution when we run the tests in parallel.
@rquitales
Use resetWaitForStack helper function instead
7571b31
@rquitales
Make stale state test serialized
ea5898e
@rquitales
Pin pulumi-kubernetes to v3.26.0 for all tests
0562e58 
There is an issue with foreground deletion propagation. Pin to v3.26.0
until we can figure out what's happening.
@rquitales
Remove unnecessary print lines
eb9e420
@rquitales rquitales added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label May 11, 2023
@rquitales rquitales marked this pull request as ready for review May 11, 2023 05:01
@rquitales rquitales requested a review from a team May 11, 2023 05:01
@rquitales rquitales merged commit 351c30b into master May 11, 2023
@rquitales rquitales deleted the rquitales/tests branch May 11, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpitzen kpitzen kpitzen approved these changes

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rquitales @kpitzen