Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack controller: watch for delete events #756

Merged
merged 4 commits into from
Nov 21, 2024
Merged

stack controller: watch for delete events #756

merged 4 commits into from
Nov 21, 2024

Conversation

EronWright
Copy link
Contributor

@EronWright EronWright commented Nov 21, 2024

Proposed changes

Ensures that progress is made if the Workspace object is deleted concurrently with the Stack object, as may occur in foreground deletion. Otherwise the operator stays idle when it should reconcile.

A partial solution is to have the Stack controller watch for Workspace 'delete' events, since the controller is otherwise stuck waiting for the workspace to become ready.

Or, the stack controller may have seen the workspace as ready, and proceeded to create an update for a non-existent workspace, which will not progress because the update controller waits for the workspace.

Also: fix a flaky test.

Related issues (optional)

Closes #753

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.75%. Comparing base (bbbad20) to head (bb63989).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...tor/internal/controller/pulumi/stack_controller.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   50.73%   50.75%   +0.02%     
==========================================
  Files          30       30              
  Lines        4173     4175       +2     
==========================================
+ Hits         2117     2119       +2     
  Misses       1872     1872              
  Partials      184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@EronWright EronWright requested a review from blampe November 21, 2024 18:47
@EronWright EronWright merged commit 81bb71b into master Nov 21, 2024
7 checks passed
@EronWright EronWright deleted the issue-753 branch November 21, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack stalls when deleted using foreground cascading delete
2 participants