Update to latest @pulumi/policy #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@pulumi/policy` library was updated to support remediations, but this repo hasn't been updated since then. This commit fixes some compile errors due to the changes there. Note: This points out that we're missing a daily cron in this repro to catch these things sooner.
justinvp
added
the
impact/no-changelog-required
This allows `yarn run tsc` for the generated test policy pack to succeed (to ensure it compiles). Otherwise, we get compiler errors like: ``` node_modules/@types/node/ts4.8/test.d.ts:881:34 - error TS1005: '?' expected. ``` due to `@types/node` using more recent TypeScript language features than TS 3.8.3. We shouldn't be relying on the version of TypeScript from `@pulumi/pulumi` anyway. If we're using `tsc`, we should declare our own dev dependency on it.
Otherwise we get an error: ``` * Your query returned no results. Please change your search criteria and try again. ```
tgummerer
approved these changes
Mar 28, 2024
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@pulumi/policylibrary was updated to support remediations, but this repo hasn't been updated since then. This commit fixes some compile errors due to the changes there.Note: This points out that we're missing a daily cron in this repro to catch these things sooner. Opened #102
Fixes #101