feat: add new securityGroupNoRuleManagementConflicts rule #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [docs](https://www.pulumi.com/registry/packages/aws/api-docs/ec2/securitygroup/) have strongly worded note about not using inline rules along with separate security group resources. This PR adds a new rule which will warn the user when they use both together. re pulumi/pulumi-aws#3788
|
Great to have a test! Code looks good. Waiting on an ack that we can ship this in this repo, similar to my other PR. |
t0yv0
reviewed
Apr 25, 2024
| export const securityGroupNoRuleManagementConflicts: StackValidationPolicy = { | ||
| name: "security-group-no-rule-management-conflicts", | ||
| description: | ||
| "Checks that ec2.SecurityGroup resources do not conflict with vpc.SecurityGroupEgressRule, vpc.SecurityGroupIngressRule, or ec2.SecurityGroupRule.\n"+ |
There was a problem hiding this comment.
The description gets printed by the CLI output, not sure how good multi-line looks there but probably readable.
t0yv0
reviewed
Apr 25, 2024
t0yv0
approved these changes
Apr 25, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
docs have strongly worded note about not using inline rules along with separate security group resources. This PR adds a new rule which will warn the user when they use both together.
re pulumi/pulumi-aws#3788