Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-provider-vantage blocked on numeric ID support #1198

Closed
t0yv0 opened this issue Jun 6, 2023 · 2 comments · Fixed by pulumi/pulumi-dnsimple#455
Closed

terraform-provider-vantage blocked on numeric ID support #1198

t0yv0 opened this issue Jun 6, 2023 · 2 comments · Fixed by pulumi/pulumi-dnsimple#455
Assignees
@iwahbe
Labels
area/plugin-framework Support for Plugin Framework based providers kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone
0.107

Comments

@t0yv0
Copy link
Member

t0yv0 commented Jun 6, 2023

What happened?

@jaxxstorm reports an issue blocking terraform-provider-vantage. Similarly to #352 the bridge assumes ID field is a string so when TF defines a numeric ID the system runs into problems. Unlike the pkg/v3 bridge, PF is also more strict by default so workarounds to pretend the ID is a string do not apply. We need to make sure this scenario works naturally:

https://github.com/vantage-sh/terraform-provider-vantage/blob/main/vantage/aws_provider_resource.go#L25

Expected Behavior

users can bridge providers with resources defining the "ID" fields as numbers.

Steps to reproduce

See above.

Output of pulumi about

N/A

Additional context

pf/v0.11.1

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@t0yv0 t0yv0 added needs-triage Needs attention from the triage team kind/bug Some behavior is incorrect or out of spec area/plugin-framework Support for Plugin Framework based providers labels Jun 6, 2023
@AaronFriel AaronFriel removed the needs-triage Needs attention from the triage team label Jun 7, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Jun 9, 2023

Related: #352

@guineveresaenger
Copy link
Contributor

Just ran into this for pulumi-dnsimple as well.

@guineveresaenger guineveresaenger mentioned this issue Dec 27, 2023
Closed
@iwahbe iwahbe mentioned this issue Jan 22, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
@iwahbe iwahbe mentioned this issue Jul 2, 2024
Merged
iwahbe added a commit that referenced this issue Jul 16, 2024
@iwahbe
[PF] Allow overriding Number with String for PF fields (#2155)
c975862 
This is motivated by [`terraform-provider-vantage blocked on numeric ID
support
#1198`](#1198).
My plan for #1198 is to override the "id" fields of each resource to be
a `"string"`, which is how we currently handle SDK based providers with
the same problem.
@iwahbe iwahbe mentioned this issue Jul 19, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jul 19, 2024
@mjeffryes mjeffryes added this to the 0.107 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwahbe iwahbe

Labels
area/plugin-framework Support for Plugin Framework based providers kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.107
Development

Successfully merging a pull request may close this issue.

Upgrade terraform-provider-dnsimple to v0.17.0 pulumi/pulumi-dnsimple
6 participants
@t0yv0 @AaronFriel @mjeffryes @guineveresaenger @iwahbe @pulumi-bot