Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlanResourceChange issue with Create timeout overrides #2386

Closed
VenelinMartinov opened this issue Sep 3, 2024 · 1 comment · Fixed by #2390
Closed

PlanResourceChange issue with Create timeout overrides #2386

VenelinMartinov opened this issue Sep 3, 2024 · 1 comment · Fixed by #2390
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented Sep 3, 2024

What happened?

Under PlanResourceChange it looks like Create timeout overrides are not respected.

Example

https://github.com/pulumi/pulumi-terraform-bridge/actions/runs/10683196988/job/29610712942?pr=2380

The test TestCustomTimeouts started failing after enabling PRC by default in the bridge.

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@VenelinMartinov VenelinMartinov added the kind/bug Some behavior is incorrect or out of spec label Sep 3, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Sep 3, 2024
@VenelinMartinov VenelinMartinov removed the needs-triage Needs attention from the triage team label Sep 3, 2024
@VenelinMartinov VenelinMartinov self-assigned this Sep 3, 2024
@VenelinMartinov VenelinMartinov removed their assignment Sep 3, 2024
@VenelinMartinov VenelinMartinov changed the title PRC issue with Create timeout overrides PlanResourceChange issue with Create timeout overrides Sep 3, 2024
@t0yv0 t0yv0 self-assigned this Sep 3, 2024
VenelinMartinov added a commit that referenced this issue Sep 4, 2024
This adds cross tests for custom timeouts, comparing our handling of
custom timeouts with terraform's. To do that we've exposed the `plan`
error in tfcheck.

Looks like the TF rules are the following:
- If the schema specifies a timeout for the operation, then the user is
allowed to override that.
- If the schema does not specify a timeout, then the resource is said
not to support timeouts. That makes it a runtime error if the user then
tries to customise the timeout on the resource.

That makes sense conceptually, as not all resources would be implemented
in a way which supports timeouts.

Related to #2386
@t0yv0 t0yv0 closed this as completed in ae899ed Sep 4, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 4, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #2390 and shipped in release v3.90.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants