Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestStacktraceDisplayed flaky test #2388

Open
VenelinMartinov opened this issue Sep 3, 2024 · 1 comment
Open

TestStacktraceDisplayed flaky test #2388

VenelinMartinov opened this issue Sep 3, 2024 · 1 comment
Assignees
Labels
kind/engineering Work that is not visible to an external user

Comments

@VenelinMartinov
Copy link
Contributor

What happened?

Looks like TestStacktraceDisplayed is flaky:

it failed on master: #2378

and on a recent PR: https://github.com/pulumi/pulumi-terraform-bridge/actions/runs/10686173033/job/29620708700?pr=2380

Example

.

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@VenelinMartinov VenelinMartinov added the kind/engineering Work that is not visible to an external user label Sep 3, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Sep 3, 2024
@iwahbe iwahbe self-assigned this Sep 4, 2024
@iwahbe iwahbe added p1 A bug severe enough to be the next item assigned to an engineer and removed needs-triage Needs attention from the triage team labels Sep 4, 2024
@iwahbe
Copy link
Member

iwahbe commented Sep 4, 2024

This doesn’t seem to be an issue reproducible with only that test. I ran the test 10,000 times locally on my laptop, and it saw no issues.

$ go test -ldflags "-X google.golang.org/protobuf/reflect/protoregistry.conflictPolicy=ignore" -test.run \^TestStacktraceDisplayed\$ -count 10000

I’m concerned that this is only reproducible by interacting TestStacktraceDisplayed with other tests.

VenelinMartinov added a commit that referenced this issue Sep 9, 2024
Skip the test until
#2388 is fixed.
@VenelinMartinov VenelinMartinov removed the p1 A bug severe enough to be the next item assigned to an engineer label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

3 participants