Revert "Allow the Type override to effect downstream types"
#1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
I agree with the revert to unblock talos and oci. That said, ExtraTypes isn't the only thing wrong here. pulumi-oci is blocked on the same error message, but it doesn't specify ExtraTypes.
|
Can you please capture everything relevant in the tracker. Appreciated. As far as I can see OCI built on pulumi/pulumi-oci#327 without an issue. |
The current OCI version builds correctly, but the new OCI version does not. 
|
|
OK I captured this in 1626 for now, we can split later on if it turns out a different issue. Thanks! Friendly reminder we need to track things.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1550
Discovered that ExtraTypes support is broken by this change per #1626