Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: type check values based on pulumi schema #1800

Merged
merged 26 commits into from
Apr 23, 2024
Merged

feat: type check values based on pulumi schema #1800

merged 26 commits into from
Apr 23, 2024

Commits on Mar 27, 2024

  1. feat: type check values based on pulumi schema 

    This adds an initial type checking implementation to `pkg/tfbridge`. The
actually type checker is pretty generic and only has a dependency on
`pulumi/pulumi` so it would be possible to pull this out into a separate
library as a general type checker.

**Feature Support**
- [X] required properties
- [X] property names
- [X] `string` types
- [X] `number` types
- [X] `object` types
- [X] `array` types
- [X] `null` types
- [X] `bool` types
- [X] `output` types
- [X] `secret` types
- [ ] `asset` types
- [ ] `archive` types
- [ ] `resourceReference` types
- [ ] String Enums
- [ ] Number Enums
    - *It knows about enums, but it does not validate enum values since
      enums are not exhaustive*

Along with the type checker it will also build an error message that
contains the path to the property.

re #1328
    @corymhall
    corymhall committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    0201d50 View commit details
    Browse the repository at this point in the history

  2. forgot to handle the difference in "integer" & "boolean" types

    @corymhall
    corymhall committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    06138b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. simplifying some things

    @corymhall
    corymhall committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    677b637 View commit details
    Browse the repository at this point in the history

  2. linting...

    @corymhall
    corymhall committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c7e3ffc View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. more updates

    @corymhall
    corymhall committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    a09ba3b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into corymhall/better-type-checking

    @corymhall
    corymhall authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    0cd1e17 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Ian Wahbe <ian@wahbe.com>
    @corymhall @iwahbe
    corymhall and iwahbe authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4e0fdf6 View commit details
    Browse the repository at this point in the history

  2. update based on comments

    @corymhall
    corymhall committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    ff1d03f View commit details
    Browse the repository at this point in the history

  3. removing logWarning

    @corymhall
    corymhall committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    abe24e8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into corymhall/better-type-checking

    @corymhall
    corymhall authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    5fb5895 View commit details
    Browse the repository at this point in the history

  5. adding comments

    @corymhall
    corymhall committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    9181a72 View commit details
    Browse the repository at this point in the history

  6. fixing linting error

    @corymhall
    corymhall committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    7957457 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. adding isComputed to exclusions

    @corymhall
    corymhall committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    fc14e02 View commit details
    Browse the repository at this point in the history

  2. refactoring some stuff

    @corymhall
    corymhall committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    79bbdef View commit details
    Browse the repository at this point in the history

  3. refactoring to PropertyPath

    @corymhall
    corymhall committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    c91835e View commit details
    Browse the repository at this point in the history

  4. fixing lint errors

    @corymhall
    corymhall committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    2d40aff View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. rebasing #1878

    @corymhall
    corymhall committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    24d52e3 View commit details
    Browse the repository at this point in the history

  2. update sync.OnceValue

    @corymhall
    corymhall committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    44a903f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into corymhall/better-ty… 

    …pe-checking
    @corymhall
    corymhall committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c41e288 View commit details
    Browse the repository at this point in the history

  4. fixing tests

    @corymhall
    corymhall committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    af83021 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. add pulumi schema to provider struct 

    remove required property validation
better oneof error messages
    @corymhall
    corymhall committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    bd62853 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into corymhall/better-ty… 

    …pe-checking
    @corymhall
    corymhall committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d9aff59 View commit details
    Browse the repository at this point in the history

  3. run go mod tidy

    @corymhall
    corymhall committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    58370dc View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. correctly read env var

    @corymhall
    corymhall committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8fa4cb3 View commit details
    Browse the repository at this point in the history

  2. fixing imports

    @corymhall
    corymhall committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    abae1a5 View commit details
    Browse the repository at this point in the history

  3. add in todo comments 

    remove oneof implementation
remove additionalproperties.ref
    @corymhall
    corymhall committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3e55e5a View commit details
    Browse the repository at this point in the history