Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated tests #2167

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

VenelinMartinov
Copy link
Contributor

These tests were added in #1800 but seem to have been misplaced in the pf folder - the tests are for the SDKV2.

The ~same tests are already present in the pkg folder under

@VenelinMartinov VenelinMartinov enabled auto-merge (squash) July 9, 2024 13:10
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.64%. Comparing base (03104a4) to head (3344681).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2167   +/-   ##
=======================================
  Coverage   60.64%   60.64%           
=======================================
  Files         350      350           
  Lines       45925    45925           
=======================================
  Hits        27852    27852           
  Misses      16533    16533           
  Partials     1540     1540           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov merged commit 8a61e44 into master Jul 9, 2024
11 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/remove_accidentally_duplicated_tests branch July 9, 2024 13:22
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.87.0.

@mjeffryes mjeffryes added this to the 0.107 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants