Infer Map[string] when the Map's element type is unspecified

[iwahbe]

SDKv2 providers allow specifying a map type without a backing element type:

schema.Schema{
	Type:     schema.TypeMap,
	Required: true,
}

Previously, the bridge interpreted this as map[any]. This does not agree with TF's interpretation: map[string]. This PR changes the bridge to correctly interpret map[???] as map[string].

Fixes pulumi/pulumi-nomad#389

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.90%. Comparing base (0f1e694) to head (4184f1f).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2316      +/-   ##
==========================================
- Coverage   56.93%   56.90%   -0.03%     
==========================================
  Files         365      365              
  Lines       49957    49961       +4     
==========================================
- Hits        28443    28431      -12     
- Misses      19973    19987      +14     
- Partials     1541     1543       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[VenelinMartinov]

Great find! Did you test this in nomad?

Can we also add an integration test for the panic?

[t0yv0]

One more case missed in #1828 it seems.

[iwahbe]

Great find! Did you test this in nomad?

Can we also add an integration test for the panic?

I tested this in nomad, the error case becomes unrepresentable. I haven't added an integration test for the panic in nomad, and we shouldn't need to:

The bridge translation ensures that (TF) Schema{Type: Map} is translated to (Pulumi) { Type: Map, Elem: {Type: String}}. As long as that holds (and it does, with tests) then SDKs (and YAML) will prevent sending malformed inputs. If a user tries to send malformed inputs, then Type-check incoming values against the Pulumi Package Schema #1328 should let them know that what they are doing is wrong (and catch the panic).

[VenelinMartinov]

That makes sense, you are saying the tfgen test is sufficient here. Sounds good