Detailed diff in cross tests #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
changed the base branch from
master
to
vvm/expand_diff_cross_tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2366 +/- ##
==========================================
- Coverage 57.66% 57.65% -0.01%
==========================================
Files 369 369
Lines 50148 50148
==========================================
- Hits 28918 28914 -4
- Misses 19650 19654 +4
Partials 1580 1580 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
changed the title
Merged
VenelinMartinov
deleted the
vvm/collection_only_detailed_diff_cross_test
branch
|
This PR has been shipped in release v3.91.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the detailed diff in the cross-test interface for both TF and Pulumi allowing us to write tests which assert on that.
Also adds a cross-test for #1696 for the existing
TestChangingMaxItems1FilterProperty. This is one of the cases where the detailed diff is load-bearing for the diff decision. The cross test verifies that TF also finds a diff here, so our core diff algorithm must be making the wrong decision.Related to #2293