Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic provider upgrade testing #194

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Mar 14, 2023

Fixes #175

Detect unexpected replace plans to prevent issues such as #173

See pulumi/pulumi-random#263 for prior art.

There is a lot of helper code temporarily included here (and also in pulumi-random) because we're out of time to properly figure out pulumi/pulumi#12125 - ideally the upgrade-style testing would be an easy to use feature of ProgramTest or similar framework and not require any helper code in providers.

@t0yv0 t0yv0 requested review from aq17 and a team March 14, 2023 16:53
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit, but otherwise LGTM!

examples/internal/testutil/testutil.go Outdated Show resolved Hide resolved
@mikhailshilkov
Copy link
Member

This looks great!

A nit: I'd love to see some description in the PR that would outline the change.

Co-authored-by: Ian Wahbe <ian@wahbe.com>
@t0yv0 t0yv0 enabled auto-merge (squash) March 15, 2023 14:19
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@t0yv0 t0yv0 merged commit fcd01c7 into master Mar 15, 2023
@t0yv0 t0yv0 deleted the t0yv0/upgrade-testing branch March 15, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement stack upgrade testing for TLS provider
4 participants