ci: Use golangci-lint-action #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinav
added
the
impact/no-changelog-required
This was referenced Aug 1, 2023
Merged
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
abhinav
force-pushed
the
abhinav/golangci-lint-action
branch
2 times, most recently
from
5fa8ea8
to
483d955
Compare
abhinav
changed the base branch from
abhinav/tidy
to
abhinav/golangci-lint-upgrade
abhinav
force-pushed
the
abhinav/golangci-lint-action
branch
from
483d955
to
5a8bac4
Compare
abhinav
force-pushed
the
abhinav/golangci-lint-upgrade
branch
from
56e26fe
to
be9412d
Compare
abhinav
force-pushed
the
abhinav/golangci-lint-action
branch
from
48c2e13
to
8958d37
Compare
abhinav
force-pushed
the
abhinav/golangci-lint-upgrade
branch
from
be9412d
to
cc40264
Compare
abhinav
force-pushed
the
abhinav/golangci-lint-action
branch
from
8958d37
to
15825cf
Compare
abhinav
force-pushed
the
abhinav/golangci-lint-upgrade
branch
from
cc40264
to
7079998
Compare
abhinav
force-pushed
the
abhinav/golangci-lint-action
branch
from
15825cf
to
7bae1fe
Compare
dixler
approved these changes
Aug 1, 2023
abhinav
force-pushed
the
abhinav/golangci-lint-upgrade
branch
from
7079998
to
f7c39e5
Compare
Instead of downloading and installing golangci-lint manually, use the golangci-lint-action. Besides caching Go-specific files, this also caches information computed by golangci-lint so lint checks should run faster. For this change, I've left the version of golangci-lint the same as what we were using previously.
Before using golangci-lint-action, lint failures were ignored
as the check was:
make lint-golang || true
This fixes the issues found by the linter minus revive's
"unused parameter" check which is not something we agree with.
This matches what we've done in pulumi/pulumi.
|
Graphite rebased this pull request as part of a merge. |
abhinav
force-pushed
the
abhinav/golangci-lint-action
branch
from
7bae1fe
to
367607b
Compare
|
Graphite couldn't merge this PR because it failed optional checks and "ignore optional checks" was not selected. |
|
Flaky test (#481). Retrying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of downloading and installing golangci-lint manually,
use the golangci-lint-action.
Besides caching Go-specific files,
this also caches information computed by golangci-lint
so lint checks should run faster.
For this change, I've left the version of golangci-lint
the same as what we were using previously.