-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web Identity and OIDC docs for pulumi-aws #3567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey hey,
Just a few changes requested.
themes/default/content/registry/packages/aws/installation-configuration.md
Outdated
Show resolved
Hide resolved
themes/default/content/registry/packages/aws/installation-configuration.md
Outdated
Show resolved
Hide resolved
themes/default/content/registry/packages/aws/installation-configuration.md
Outdated
Show resolved
Hide resolved
9666142
to
ab3048d
Compare
ab3048d
to
16379d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your site preview for commit 16379d4 is ready! 🎉 http://registry--origin-pr-3567-16379d47.s3-website.us-west-2.amazonaws.com/registry. Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete. |
Site previews for this pull request have been removed. ✨ |
Test web identity (OIDC) authentication in CI for regression testing. The approach is to pick one of the existing tests in `examples` and run it two additional times, authenticating via web identity/OIDC: 1. via the GH action `aws-actions/configure-aws-credentials` 2. manually via retrieving the token from GH and configuring the provider with it. I don't love the duplication of much of the workflow definition for YAML but at this time that's the trade-off for using ci-mgmt. Related: #3084, pulumi/registry#3567
Add some setup instructions for web identity+OIDC authentication to resolve pulumi/pulumi-aws#2425.