Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Identity and OIDC docs for pulumi-aws #3567

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Conversation

thomas11
Copy link
Contributor

Add some setup instructions for web identity+OIDC authentication to resolve pulumi/pulumi-aws#2425.

@thomas11 thomas11 marked this pull request as draft November 28, 2023 13:52
@thomas11 thomas11 requested review from toriancrane and a team November 29, 2023 16:01
Copy link
Contributor

@toriancrane toriancrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey hey,

Just a few changes requested.

@thomas11 thomas11 changed the title Draft of web identity+OIDC docs for p-aws Web Identity and OIDC docs for pulumi-aws Dec 1, 2023
@thomas11 thomas11 marked this pull request as ready for review December 4, 2023 17:04
@thomas11 thomas11 requested a review from a team December 5, 2023 06:43
@pulumi pulumi deleted a comment from github-actions bot Dec 5, 2023
Copy link
Contributor

@toriancrane toriancrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Dec 5, 2023

Your site preview for commit 16379d4 is ready! 🎉

http://registry--origin-pr-3567-16379d47.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

@thomas11 thomas11 merged commit 864d3ec into master Dec 6, 2023
3 checks passed
@thomas11 thomas11 deleted the tkappler/aws-oidc branch December 6, 2023 14:12
Copy link

github-actions bot commented Dec 6, 2023

Site previews for this pull request have been removed. ✨

thomas11 added a commit to pulumi/pulumi-aws that referenced this pull request Dec 20, 2023
Test web identity (OIDC) authentication in CI for regression testing.

The approach is to pick one of the existing tests in `examples` and run
it two additional times, authenticating via web identity/OIDC:
1. via the GH action `aws-actions/configure-aws-credentials`
2. manually via retrieving the token from GH and configuring the provider with it.

I don't love the duplication of much of the workflow definition for YAML but at this time that's the trade-off for using ci-mgmt.

Related: #3084, pulumi/registry#3567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for Web Identity / OIDC configuration
2 participants