Fix serving public/index.html as a static file #234
Conversation
nonrational
changed the title
|
h/t @momolog for pushing on this issue and providing critical debugging feedback. |
| @@ -72,7 +72,7 @@ func launchPumaDevBackgroundServerWithDefaults(t *testing.T) func() { | |||
| } | |||
| } | |||
|
|
|||
| func getUrlWithHost(t *testing.T, url string, host string) string { | |||
| func getURLWithHost(t *testing.T, url string, host string) string { | |||
There was a problem hiding this comment.
golint wants URL not Url
| @@ -0,0 +1 @@ | |||
| <html><h1>index.html</h1></html> | |||
There was a problem hiding this comment.
this should never show up. it's included here to verify that we weren't able to look outside the public directory.
| http.ServeFile(w, req, path) | ||
| return httputil.ErrHandled | ||
| if ofile, err := os.Open(path); err == nil { | ||
| http.ServeContent(w, req, req.URL.Path, fi.ModTime(), io.ReadSeeker(ofile)) |
There was a problem hiding this comment.
https://golang.org/pkg/net/http/#ServeFile
As another special case,
ServeFileredirects any request wherer.URL.Pathends in "/index.html" to the same path, without the final "index.html". To avoid such redirects either modify the path or useServeContent.
There was a problem hiding this comment.
the downside with this approach is that you can't just drop an index.html in public and go to mysite.localhost. you have to navigate to mysite.localhost/index.html.
but, puma-dev never supported that anyway, given the req.URL.Path != "/"
I figure this is a good enhancement to consider when tackling #87
There was a problem hiding this comment.
I think this is fine, your justification makes sense.
nonrational
changed the title
| http.ServeFile(w, req, path) | ||
| return httputil.ErrHandled | ||
| if ofile, err := os.Open(path); err == nil { | ||
| http.ServeContent(w, req, req.URL.Path, fi.ModTime(), io.ReadSeeker(ofile)) |
There was a problem hiding this comment.
I think this is fine, your justification makes sense.
This PR serves to illustrate behavior discussed in #140 and #87.Fixes #140 (at least the part of it that is not covered by #87)
As of 0.13,
puma-devdoes not support serving "naked" static files without bootingpuma. It can, of course, be modified to support such behavior (see #87).The headline here is #234 (comment)
Changes
static-site) with apublicdirectory containinggreeting.txtGET localhost/greeting.txtis handled bypuma-devGET localhost/foois handled by rack.golintwarnings about usingUrlinstead ofURLvariable names.ServeContentto avoid redirectingindex.htmlback to/. See No static content serving on test domain #140 (comment)