Prevent apps with the same folder name to colide #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this commit if two symlinks were targeting distinct folders having the same name the app were considered to be the same
|
@nonrational anything I can do? |
nonrational
approved these changes
Jan 11, 2021
|
All set. 0.15.2 is in Homebrew. Thank you! |
jorgemanrubia
added a commit
to jorgemanrubia/puma-dev
that referenced
this pull request
Jul 9, 2021
This fixes a problem where it fails to reuse the same instance of the app when using multiple hostnames with different names (multiple symlinks pointing to the same folder). The bug was introduced in puma#270. The patch is based on adding the checksum in all cases when a symlink is involved, not only when the names don't match. If not, it can happen that it's not added if the name matches for the first execution, which results in not finding the app instance later, resulting in an error "There is already a server bound to..." Fixes puma#280
nonrational
pushed a commit
that referenced
this pull request
Jul 9, 2021
This fixes a problem where it fails to reuse the same instance of the app when using multiple hostnames with different names (multiple symlinks pointing to the same folder). The bug was introduced in #270. The patch is based on adding the checksum in all cases when a symlink is involved, not only when the names don't match. If not, it can happen that it's not added if the name matches for the first execution, which results in not finding the app instance later, resulting in an error "There is already a server bound to..." Fixes #280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Before this commit if two apps were resolving their symlinks to distinct folders with the same name, the first app booted was used to serve queries targeting the other app.
example:
both content and platform rails app were served by the first of the two apps being booted
With this commit a checksum of the full app path is being added to the app name, which maintain the existing behavior of having a single app booted even if several symlinks are targeting it, but distinct folders with the same name are now treated as different apps
consequences
logs are now displaying lines with the app name suffixed by the folder path checksum: