Add support for multipart TLDs #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @yoerayo! Looks like this enhancement will obviate the symlink workarounds necessary to configure domains and not just TLDs. I'm going to merge as is and then add a note to the readme. Will cut a new release in the next few days after kicking the tires a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of puma-dev doesn't actually take the configured domains into account when resolving apps, so anything other than a very simple TLD fails to resolve properly. This PR attempts to remove the configured TLDs from the requested host before falling back to the old method of just stripping everything after and including the last period from the host.