Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

race and linter fixes #291

Merged
merged 10 commits into from
Feb 1, 2022
Merged

race and linter fixes #291

merged 10 commits into from
Feb 1, 2022

Conversation

nonrational
Copy link
Member

@nonrational nonrational commented Nov 23, 2021

  • error strings should not be capitalized or end with punctuation or a newline
  • sort.Sort is in-place, so we shouldn't do it inside a request with a shared copy of http. instead, sort on main init, since the list of domains won't change without a restart.
  • macOS' firewall is finicky about letting go bind and serve DNS inside tests, so leaning on GitHub CI to run on every push

note: I'm seeing this really weird behavior locally where make test backgrounds itself, so still trying to figure out if I somehow caused that with these changes or if it's an environmental thing. it's an environmental thing related to not have puma installed for the system ruby.

@nonrational nonrational marked this pull request as ready for review January 9, 2022 16:06
@nonrational nonrational merged commit ff4e254 into master Feb 1, 2022
@nonrational nonrational deleted the race-and-lint-fixes branch February 1, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant