Add better logs for missing component references #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously some users would not notice if a component was missing a connection, or did not know what to do in this case. This should make this a bit clearer to users.
papr
suggested changes
Jul 23, 2020
Co-authored-by: Pablo Prietz <pablo@prietz.org>
papr
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously some users would not notice if a component was missing a connection, or did not know what to do in this case. This PR should make this a bit clearer to users by telling them which reference is missing from which component and that they need to connect them manually. It also logs an error instead of a warning since the component won't function correctly in this case.
This is especially important since we offer a range of ready-to-use prefabs, which still require to be hooked up correctly to the scene. Just dragging them in would not work because of missing references.