Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated sending of reference data #99

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

pfaion
Copy link
Contributor

@pfaion pfaion commented Jul 21, 2020

We only send the reference point, which is independent of the eye-id.

✔️ Tested by calibrating with a core headset connected to Unity. The calibration was bad (as to be expected), but everything worked fine.

We only send the reference point, which is independent of the eye-id
@pfaion pfaion requested a review from papr July 21, 2020 14:30
Copy link
Contributor

@papr papr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks correct. Please test with VR setup. Once you can confirm it works, please merge.

@pfaion
Copy link
Contributor Author

pfaion commented Jul 22, 2020

✔️ also tested with the HMD now.

@pfaion pfaion merged commit d025662 into master Jul 22, 2020
@pfaion pfaion deleted the calibration-without-eyeid branch July 22, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants