-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modules 1192 - rename facts param on actionpolicy::rule to remove conflict with $facts hash #161
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
require 'spec_helper' | ||
|
||
describe 'mcollective::actionpolicy::rule', :type => :define do | ||
context 'default-puppet' do | ||
let(:title) { 'default-puppet' } | ||
let(:params) do | ||
{ | ||
:agent => 'puppet', | ||
} | ||
end | ||
|
||
it { | ||
should contain_datacat_fragment('mcollective::actionpolicy::rule default-puppet') \ | ||
.with_target('mcollective::actionpolicy puppet') \ | ||
.with_data({ | ||
'lines' => [ | ||
{ | ||
'action' => 'allow', | ||
'callerid' => '*', | ||
'actions' => '*', | ||
'facts' => '*', | ||
'classes' => '*', | ||
}, | ||
], | ||
}) | ||
} | ||
end | ||
|
||
context 'facts-specified' do | ||
let(:title) { 'default-puppet' } | ||
let(:params) do | ||
{ | ||
:agent => 'puppet', | ||
:fact_filter => 'environment=dev and !customer=acme', | ||
} | ||
end | ||
|
||
it { | ||
should contain_datacat_fragment('mcollective::actionpolicy::rule default-puppet') \ | ||
.with_target('mcollective::actionpolicy puppet') \ | ||
.with_data({ | ||
'lines' => [ | ||
{ | ||
'action' => 'allow', | ||
'callerid' => '*', | ||
'actions' => '*', | ||
'facts' => 'environment=dev and !customer=acme', | ||
'classes' => '*', | ||
}, | ||
], | ||
}) | ||
} | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
policy default <%= @data['default'] %> | ||
<% | ||
lines = @data['lines'].collect do |line| | ||
line.values_at(*%w{ action callerid actions facts classes }).join("\t") | ||
line.values_at(*%w{ action callerid actions fact_filter classes }).join("\t") | ||
end | ||
-%> | ||
<%= lines.sort.join("\n") %> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not necessary, because the hash still has the key facts:
https://github.com/puppet-community/puppet-mcollective/pull/161/files#diff-26b416a07573e48cd8576ce727abff8aL18
You break the policy file with that change