Skip to content

Commit

Permalink
(PA-6393) Let '' (empty string) be an acceptable networking dhcp fact…
Browse files Browse the repository at this point in the history
… for all fedora versions

 - Fedora is susceptible to a bug in NetworkManager that causes it to fail networking_facts acceptance test.
 - This commit makes '' the acceptable value for networking dhcp fact in Fedora, so CI passes the test.
 - Since all Fedora versions seem to be having the issue, its been made generic to all versions in this commit.
 - See #2515
  • Loading branch information
shubhamshinde360 committed May 6, 2024
1 parent d04a42d commit 65a840c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion acceptance/tests/facts/networking_facts.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

agents.each do |agent|
expected_networking = {
%w[networking dhcp] => agent['platform'] =~ /fedora-32|fedora-34|fedora-36|el-8-|el-9-/ ? '' : @ip_regex, # https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/426
%w[networking dhcp] => agent['platform'] =~ /fedora-|el-8-|el-9-/ ? '' : @ip_regex, # https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/426
%w[networking ip] => @ip_regex,
%w[networking ip6] => /[a-f0-9]+:+/,
%w[networking mac] => /[a-f0-9]{2}:/,
Expand Down

0 comments on commit 65a840c

Please sign in to comment.