facter: change sys-filesystem to a runtime dep #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change sys-filesystem was listed as a development dependency, to avoid requiring a C compiler when performing a gem install. However, this produces a version of facter whose mountpoints fact and partitions facts are broken. Re-visit the decision and prefer to produce a fully functional facter version. This issue was discovered when using facter in Debian, where the lack of a dependency on sys-filesystem produces a package with broken mountpoints and partitions facts.
|
Can one of the admins verify this patch? |
|
Debian bug for reference, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1089174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change sys-filesystem was listed as a development dependency, to avoid requiring a C compiler when performing a gem install. However, this produces a version of facter whose mountpoints fact and partitions facts are broken. Re-visit the decision and prefer to produce a fully functional facter version.
This issue was discovered when using facter in Debian, where the lack of a dependency on sys-filesystem produces a package with broken mountpoints and partitions facts.