Use rspec-mocks as default mocking library #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
added a commit
to DavidS/pdk
that referenced
this pull request
Feb 16, 2021
With puppet5's EOL, all supported configurations now have the rsapi gem in the default gemset. See puppetlabs/pdk-templates#404 for the second part of this work.
|
@DavidS please add the |
Previously puppetlabs_spec_helper was loading both rspec-mocks and mocha. This leads to confusing inconsistencies in unit tests. For the longest time we've been recommending people to default to rspec-mocks. This commit makes it official for PDK2.0. If your test suite is not yet ready for this step, remove the default value through setting `mock_with: ~` (YAML's nil value) to get the PDK1.x behavior.
DavidS
force-pushed
the
make-rspec-default-mock
branch
from
dec281c
to
eef1ed5
Compare
|
@cdenneen good call. Updated the README. |
michaeltlombardi
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously puppetlabs_spec_helper was loading both rspec-mocks and mocha.
This leads to confusing inconsistencies in unit tests. For the longest time
we've been recommending people to default to rspec-mocks. This commit
makes it official for PDK2.0.
If your test suite is not yet ready for this step, remove the default value
through setting
mock_with: ~(YAML's nil value) to get the PDK1.x behavior.