Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SDK-319) force usage of our ruby #168

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Jul 18, 2017

When running commands in module context, we always want to use our private
ruby. Especially bundler's binstubs are using ruby from the PATH, which
led to weird failures, as the multiple rubies would not agree on installed
gems, etc.

When running commands in module context, we always want to use our private
ruby. Especially bundler's binstubs are using ruby from the PATH, which
led to weird failures, as the multiple rubies would not agree on installed
gems, etc.
@james-stocks james-stocks merged commit 7448a70 into puppetlabs:master Jul 18, 2017
@scotje
Copy link
Contributor

scotje commented Jul 18, 2017

Is there a reason we aren't using @process.environment to do this instead of all the begin/ensure business?

@DavidS
Copy link
Contributor Author

DavidS commented Jul 18, 2017

@scotje nothing worse than my incompetence

@DavidS DavidS deleted the pdk-319-pathing branch July 18, 2017 16:22
@scotje
Copy link
Contributor

scotje commented Jul 18, 2017

OK, I'll lump in a simplification with my bundle path fix then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants