(PDK-365) Inform and prompt user following new module generate #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to add unit tests. |
DavidS
reviewed
Aug 25, 2017
| shared_context 'allow post generate info to be printed to stdout' do | ||
| before(:each) do | ||
| allow($stdout).to receive(:puts).with(a_string_matching(%r{module.*generated at path.*}i)) | ||
| allow($stdout).to receive(:puts).with(a_string_matching(%r{In your new module directory, add classes with the 'pdk new class' command}i)) |
There was a problem hiding this comment.
shouldn't that be expect post generate info...?
There was a problem hiding this comment.
Yep. New updates should reflect actual testing. lol.
scotje
reviewed
Aug 25, 2017
| if FileUtils.mv(temp_target_dir, target_dir) | ||
| PDK.logger.info(_('Module \'%{name}\' generated at path \'%{path}\'.') % { name: opts[:name], path: target_dir }) | ||
| PDK.logger.info(_('In your new module directory, add classes with the \'pdk new class\' command.')) | ||
| end |
There was a problem hiding this comment.
Is it possible for FileUtils.mv to fail without raising an exception?
There was a problem hiding this comment.
Sorry, I should have clarified the point of my question which was, why do we need that conditional around the log lines?
rodjek
approved these changes
Aug 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon successful generation of a new module, inform the user: